GH-39666: [C++] Ensure CSV and JSON benchmarks present a bytes/s or items/s metric #39764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s or items/s metric
cyb70289
approved these changes
Jan 23, 2024
github-actions
bot
added
awaiting committer review
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3fe598a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…s or items/s metric (apache#39764) ### Rationale for this change Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret. ### What changes are included in this PR? Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense. ### Are these changes tested? Manually. ### Are there any user-facing changes? No. * Closes: apache#39666 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…s or items/s metric (apache#39764) ### Rationale for this change Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret. ### What changes are included in this PR? Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense. ### Are these changes tested? Manually. ### Are there any user-facing changes? No. * Closes: apache#39666 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…s or items/s metric (apache#39764) ### Rationale for this change Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret. ### What changes are included in this PR? Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense. ### Are these changes tested? Manually. ### Are there any user-facing changes? No. * Closes: apache#39666 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some of our microbenchmarks only present an iteration time in (nano,micro...)seconds. That is usually tedious to read and difficult to interpret.
What changes are included in this PR?
Ensure that benchmarks present a items/seconds and/or a bytes/seconds metric where that makes sense.
Are these changes tested?
Manually.
Are there any user-facing changes?
No.